linux-kernel - Re: [PATCH 2/2] xen: xenbus: WARN_ON XS_TRANSACTION

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66103cca-321e-6950-2083-6f5d068e12e6@invisiblethingslab.com>
Date:   Sun, 11 Feb 2018 01:27:00 +0000
From:   Simon Gaiser <simon@...isiblethingslab.com>
To:     Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        xen-devel@...ts.xenproject.org
Cc:     Juergen Gross <jgross@...e.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] xen: xenbus: WARN_ON XS_TRANSACTION_{START,END}
 misuse

Boris Ostrovsky:
> On 02/07/2018 05:22 PM, Simon Gaiser wrote:
>> +    users_old = xs_state_users;
>>       xs_state_users--;
>>       if ((req->type == XS_TRANSACTION_START && req->msg.type == XS_ERROR) ||
>>           req->type == XS_TRANSACTION_END)
>>           xs_state_users--;
>> +    if (WARN_ON(xs_state_users > users_old))
> 
> 
> WARN_ON_ONCE()?

Since we "fix" the wrong decrement by clamping at zero it should not
happen immediately again. But if you prefer _ONCE I can change it.



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)