linux-kernel - Re: [PATCH] x86/speculation: Clean up various Spectre related details

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180211194305.zg7tq3x3cxjuphyo@gmail.com>
Date:   Sun, 11 Feb 2018 20:43:05 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     David Woodhouse <dwmw2@...radead.org>
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org, tglx@...utronix.de,
        karahmed@...zon.de, sironi@...zon.de, kvm@...r.kernel.org,
        torvalds@...ux-foundation.org, pbonzini@...hat.com, bp@...en8.de,
        peterz@...radead.org, jmattson@...gle.com, rkrcmar@...hat.com,
        arjan.van.de.ven@...el.com, dave.hansen@...el.com
Subject: Re: [PATCH] x86/speculation: Clean up various Spectre related details


* David Woodhouse <dwmw2@...radead.org> wrote:

> 
> 
> On Sun, 2018-02-11 at 19:50 +0100, Ingo Molnar wrote:
> > 
> > From 82c2b2f29691143a05181333f387e786646aa28b Mon Sep 17 00:00:00 2001
> > From: Ingo Molnar <mingo@...nel.org>
> > Date: Sat, 10 Feb 2018 11:51:57 +0100
> > Subject: [PATCH] x86/speculation: Clean up various Spectre related details
> > 
> > Harmonize all the Spectre messages so that a:
> > 
> >     dmesg | grep -i spectre
> > 
> > ... gives us most Spectre related kernel boot messages.
> > 
> > Also fix a few other details:
> > 
> >  - clarify a comment about firmware speculation control
> > 
> >  - s/KPTI/PTI
> > 
> >  - remove various line-breaks that made the code uglier
> > 
> > Cc: Andy Lutomirski <luto@...nel.org>
> > Cc: Arjan van de Ven <arjan@...ux.intel.com>
> > Cc: Borislav Petkov <bp@...en8.de>
> > Cc: Dan Williams <dan.j.williams@...el.com>
> > Cc: Dave Hansen <dave.hansen@...ux.intel.com>
> > Cc: David Woodhouse <dwmw2@...radead.org>
> > Cc: David Woodhouse <dwmw@...zon.co.uk>
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Cc: Josh Poimboeuf <jpoimboe@...hat.com>
> > Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> > Cc: Peter Zijlstra <peterz@...radead.org>
> > Cc: Thomas Gleixner <tglx@...utronix.de>
> > Signed-off-by: Ingo Molnar <mingo@...nel.org>
> 
> 
> 
> Acked-by: David Woodhouse <dwmw@...zon.co.uk>

Thanks, added.

> with a couple of comments:
> 
> 
> -        * If neither SMEP or KPTI are available, there is a risk of
> +        * If neither SMEP or PTI are available, there is a risk of
> 
> Make that 'neither SMEP nor PTI' while you're at it though please;
> that's bugged me a couple of times in passing.

Ok, fixed that too.

> 
> And should these say 'Spectre v2' not just 'Spectre'?

Yeah, you are probably right, but I didn't want to make the messages too specific 
- do we really know that this is the end of Spectre-style speculation holes?

Thanks,

	Ingo