linux-kernel - Re: [PATCH char-misc 1/1] Drivers: hv: vmbus: Fix ring buffer signaling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20180211155047.7859be96@xeon-e3>
Date:   Sun, 11 Feb 2018 15:50:47 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Michael Kelley <mhkelley@...look.com>
Cc:     "mikelley@...rosoft.com" <mikelley@...rosoft.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
        "olaf@...fle.de" <olaf@...fle.de>,
        "apw@...onical.com" <apw@...onical.com>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        "jasowang@...hat.com" <jasowang@...hat.com>,
        "leann.ogasawara@...onical.com" <leann.ogasawara@...onical.com>,
        "marcelo.cerri@...onical.com" <marcelo.cerri@...onical.com>,
        "sthemmin@...rosoft.com" <sthemmin@...rosoft.com>,
        "kys@...rosoft.com" <kys@...rosoft.com>
Subject: Re: [PATCH char-misc 1/1] Drivers: hv: vmbus: Fix ring buffer
 signaling

On Sat, 10 Feb 2018 20:48:49 +0000
Michael Kelley <mhkelley@...look.com> wrote:

> +	u32 delta = rbi->ring_buffer->read_index < rbi->priv_read_index ?
> +			(rbi->priv_read_index - rbi->ring_buffer->read_index) :
> +			(rbi->ring_datasize - rbi->ring_buffer->read_index +
> +			rbi->priv_read_index);
>  

Would it would make sense for this to be a wrapper function like other ring operations?