linux-kernel - Re: [PATCH 8/8] ASoC: samsung,tm2-audio DT binding documentation update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJKOXPezeWHCaHz1PY03_nTFxb0qOCsgPtNjfMC4id0DsrFLqA@mail.gmail.com>
Date:   Mon, 12 Feb 2018 10:19:27 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Sylwester Nawrocki <s.nawrocki@...sung.com>
Cc:     broonie@...nel.org, lgirdwood@...il.com,
        alsa-devel@...a-project.org, robh+dt@...nel.org,
        devicetree@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        jcsing.lee@...sung.com, sbkim73@...sung.com,
        linux-kernel@...r.kernel.org,
        Bartłomiej Żołnierkiewicz 
        <b.zolnierkie@...sung.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH 8/8] ASoC: samsung,tm2-audio DT binding documentation update

On Wed, Feb 7, 2018 at 5:31 PM, Sylwester Nawrocki
<s.nawrocki@...sung.com> wrote:
> On 02/06/2018 02:05 PM, Krzysztof Kozlowski wrote:
>> On Mon, Feb 5, 2018 at 4:44 PM, Sylwester Nawrocki
>> <s.nawrocki@...sung.com> wrote:
>>> This patch documents additional entries of the audio-codec and
>>> i2s-controller properties required for the HDMI audio support.
>>>
>>> Signed-off-by: Sylwester Nawrocki <s.nawrocki@...sung.com>
>>> ---
>>>  .../devicetree/bindings/sound/samsung,tm2-audio.txt        | 14 +++++++++-----
>>>  1 file changed, 9 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/sound/samsung,tm2-audio.txt b/Documentation/devicetree/bindings/sound/samsung,tm2-audio.txt
>>> index 94442e5673b3..f5ccc12ddc00 100644
>>> --- a/Documentation/devicetree/bindings/sound/samsung,tm2-audio.txt
>>> +++ b/Documentation/devicetree/bindings/sound/samsung,tm2-audio.txt
>>> @@ -4,9 +4,13 @@ Required properties:
>>>
>>>   - compatible           : "samsung,tm2-audio"
>>>   - model                : the user-visible name of this sound complex
>>> - - audio-codec          : the phandle of the wm5110 audio codec node,
>>> -                          as described in ../mfd/arizona.txt
>>> - - i2s-controller       : the phandle of the I2S controller
>>> + - audio-codec          : the first entry should be phandle of the wm5110 audio
>>> +                          codec node, as described in ../mfd/arizona.txt;
>>> +                          the second entry should be phandle of the HDMI
>>
>> AFAIU, this property is still optional so the wording should be
>> different. Maybe just add "optional properties" paragraph?
>
> I'd like to keep the second entries required in the documentation,
> and the driver would still be handling the case with just single
> entries.

I understand.
Acked-by: Krzysztof Kozlowski <krzk@...nel.org>

Best regards,
Krzysztof