linux-kernel - Re: update spectre v2 microcodes blacklist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1518428086.6606.11.camel@infradead.org>
Date:   Mon, 12 Feb 2018 09:34:46 +0000
From:   David Woodhouse <dwmw2@...radead.org>
To:     Alexander Sergeyev <sergeev917@...il.com>,
        "Van De Ven, Arjan" <arjan.van.de.ven@...el.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Kyle Huey <me@...ehuey.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Levin, Alexander (Sasha Levin)" <alexander.levin@...izon.com>,
        Peter Zijlstra <peterz@...radead.org>,
        linux-kernel@...r.kernel.org
Subject: Re: update spectre v2 microcodes blacklist

On Sat, 2018-02-10 at 20:14 +0300, Alexander Sergeyev wrote:
> > 
> > I didn't fully match the updated revision guidance and spectre_bad_microcodes
> I compared these lists and it seems that the only difference is about skylakes. 
> Everything else is covered by less-or-equal criteria on revision version.
> 
> Both desktop and mobile skylakes are stated to be unaffected for 0xC2:
> 
> { INTEL_FAM6_SKYLAKE_DESKTOP,    0x03, 0xc2 }, // signature 0x000506E3
> { INTEL_FAM6_SKYLAKE_MOBILE,     0x03, 0xc2 }, // signature 0x000406E3
> 
> I reformated the Intel bulletin into json format for ease of automation and 
> batch processing -- it is attached.
> 
> Raw diff between the mainline blacklist and the bulletin looks like:
> @@ -1,5 +1,6 @@
>  { INTEL_FAM6_BROADWELL_CORE,     0x04, 0x28 },
>  { INTEL_FAM6_BROADWELL_GT3E,     0x01, 0x1b },
> +{ INTEL_FAM6_BROADWELL_X,        0x01, 0x0b000023 },
>  { INTEL_FAM6_BROADWELL_X,        0x01, 0x0b000025 },

That's redundant since blacklisting 0x0b000025 will also stop us from
using 0x0b000023 anyway.

> -{ INTEL_FAM6_KABYLAKE_DESKTOP,   0x09, 0x84 },
> -{ INTEL_FAM6_KABYLAKE_DESKTOP,   0x0a, 0x84 },
> -{ INTEL_FAM6_KABYLAKE_DESKTOP,   0x0b, 0x84 },
> -{ INTEL_FAM6_KABYLAKE_MOBILE,    0x09, 0x84 },
> -{ INTEL_FAM6_KABYLAKE_MOBILE,    0x0a, 0x84 },

No, let's not assume 0x84 will be safe on those just yet. Intel
mentioned 0x84 as bad in one of the revisions of the doc, and it's
safer to leave it blacklisted until they explicitly say otherwise.

> -{ INTEL_FAM6_SKYLAKE_DESKTOP,    0x03, 0xc2 },
> -{ INTEL_FAM6_SKYLAKE_MOBILE,     0x03, 0xc2 },

OK. With 0xc2 being exonerated, I believe there is *no* publicly
released microcode for these which needs to be blacklisted, so they can
be removed entirely.

> -{ INTEL_FAM6_SKYLAKE_X,          0x03, 0x0100013e },

Again, that appeared in an earlier version of the document and hasn't
been explicitly cleared.

> +{ INTEL_FAM6_SKYLAKE_X,          0x04, 0x0200003a },
>  { INTEL_FAM6_SKYLAKE_X,          0x04, 0x0200003c },

Redundant again.

> Note: Gemini Lake and Sandy Bridge are not considered (observed in wild).

Ah, but we have more information now from the doc. 

The Gemini Lake 0x22 was observed in the wild, sure, but is also
explicitly mentioned as OK in the latest doc. So I removed it from the
blacklist (again, with no prior Gemini Lake bad microcode, so the line
can be removed entirely).

The Sandy Bridge ones observed in the wild are, however, *newer* than
the "Pre-Mitigation Production MCU" listed for the corresponding CPU in
the table, and thus we should assume they should still be blacklisted.
Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (5213 bytes)