linux-kernel - Re: [PATCH v2 04/11] watchdog/hpwdt: white space changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOFm3uH0PUXVOxJmqDf-ZCm8vTp_6ERwYSC6Bt2-8r-C2yH9gQ@mail.gmail.com>
Date:   Mon, 12 Feb 2018 10:35:50 +0100
From:   Philippe Ombredanne <pombredanne@...b.com>
To:     Jerry Hoemann <jerry.hoemann@....com>
Cc:     wim@...ux-watchdog.org, Guenter Roeck <linux@...ck-us.net>,
        linux-watchdog@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>, rwright@....com,
        maurice.a.saldivar@....com
Subject: Re: [PATCH v2 04/11] watchdog/hpwdt: white space changes

Jerry,

On Mon, Feb 12, 2018 at 6:21 AM, Jerry Hoemann <jerry.hoemann@....com> wrote:
> Minor white space changes and some name clean up.
>
> Signed-off-by: Jerry Hoemann <jerry.hoemann@....com>
> ---
>  drivers/watchdog/hpwdt.c | 49 +++++++++++++++++++++++-------------------------
>  1 file changed, 23 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
> index 6f7949ef9a23..ee9a92220ece 100644
> --- a/drivers/watchdog/hpwdt.c
> +++ b/drivers/watchdog/hpwdt.c
> @@ -1,11 +1,9 @@
>  /*
>   *     HPE WatchDog Driver
> - *     based on
>   *
> - *     SoftDog 0.05:   A Software Watchdog Device
> - *
> - *     (c) Copyright 2015 Hewlett Packard Enterprise Development LP
> + *     (c) Copyright 2018 Hewlett Packard Enterprise Development LP
>   *     Thomas Mingarelli <thomas.mingarelli@....com>
> + *     Jerry Hoemann <jerry.hoemann@....com>
>   *
>   *     This program is free software; you can redistribute it and/or
>   *     modify it under the terms of the GNU General Public License

Since you are updating the copyright, why not updating the licensing
to use the new concise SPDX ids instead? [1]
And you get a big good karma bonus if you can also do the same for all
HPE-copyrighted files, tree-wide ;) and/or spread the word inside your
team.

Thank you for your kind consideration!

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst

Cordially
Philippe Ombredanne