linux-kernel - Re: [PATCH] drm/edid: drop the dcc probe before drm_do_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87tvum7di0.fsf@intel.com>
Date:   Mon, 12 Feb 2018 11:39:51 +0200
From:   Jani Nikula <jani.nikula@...el.com>
To:     Lubomir Rintel <lkundrak@...sk>, dri-devel@...ts.freedesktop.org
Cc:     linux-kernel@...r.kernel.org, David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel.vetter@...el.com>,
        Sean Paul <seanpaul@...omium.org>
Subject: Re: [PATCH] drm/edid: drop the dcc probe before drm_do_get_edid

On Sun, 11 Feb 2018, Lubomir Rintel <lkundrak@...sk> wrote:
> On Sat, 2018-02-10 at 19:03 +0100, Lubomir Rintel wrote:
>> Now that drm_do_get_edid() handles override and firmware EDIDs it makes
>> no sense to conditionalize it with a DCC probe. On the contrary -- the
>> overrides are useful specifically when DCC is not functioning.
>> 
>> drm_do_get_edid() already bails out when DCC fails, there's no need for
>> an extra check. It seems entirely safe to just drop this.
>> 
>> Working around the issue by forcing the connector on is not a good
>> solution because that way the desktop shell can't tell when a monitor is
>> plugged in or removed.
>> 
>> Cc: Jani Nikula <jani.nikula@...el.com>
>> Fixes: 53fd40a ("drm: handle override and firmware EDID at drm_do_get_edid() level")
>
> Please disregard this, should have given it more thought. Sorry.
>
> It removes a symbol other modules use, and typoes DDC/DCC in the commit
> message. Moreover it doesn't actually seem to solve my problem -- will
> try to follow up with a better fix.

I think the ddc probe was originally added for a reason. What that
reason was, I have no idea. I suggest you go on a bit of git blame/log
history digging to find what it was before removing.

Anyway, as you can see from the code, you can still use connector
forcing to bypass the ddc check.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center