linux-kernel - Re: linux-4.16-rc1/drivers/misc/ocxl/file.c:320:broken error checking ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <6e051309-c236-7715-cffb-b53d2da600b3@linux.vnet.ibm.com>
Date:   Mon, 12 Feb 2018 10:53:02 +0100
From:   Frederic Barrat <fbarrat@...ux.vnet.ibm.com>
To:     David Binderman <dcb314@...mail.com>,
        "andrew.donnellan@....ibm.com" <andrew.donnellan@....ibm.com>,
        "arnd@...db.de" <arnd@...db.de>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: linux-4.16-rc1/drivers/misc/ocxl/file.c:320:broken error checking
 ?



Le 12/02/2018 à 09:58, David Binderman a écrit :
> Hello there,
> 
> 
> linux-4.16-rc1/drivers/misc/ocxl/file.c:320]: (style) Checking if 
> unsigned variable 'used' is less than zero.
> 
> Source code is
> 
> 
>         used = append_xsl_error(ctx, &header, buf + sizeof(header));
>          if (used < 0)
>              return used;
> 
> Suggest put return value from function into signed variable, sanity 
> check it,
> 
> then assign it to an unsigned variable.
> 
> 
> Also, use of the gcc compiler flag -Wtype-limits will show up this kind 
> of problem in future.

Thanks for reporting it. A patch to address it is working its way up and 
should land in the next rc release.

   Fred


> 
> Regards
> 
> 
> David Binderman
> 
>