linux-kernel - Re: [PATCH] MAINTAINERS: add Freescale pin controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1518435295.2744.7.camel@pengutronix.de>
Date:   Mon, 12 Feb 2018 12:34:55 +0100
From:   Lucas Stach <l.stach@...gutronix.de>
To:     Baruch Siach <baruch@...s.co.il>
Cc:     Stefan Agner <stefan@...er.ch>, linus.walleij@...aro.org,
        aisheng.dong@....com, fabio.estevam@....com, shawnguo@...nel.org,
        kernel@...gutronix.de, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] MAINTAINERS: add Freescale pin controllers

Am Montag, den 12.02.2018, 13:22 +0200 schrieb Baruch Siach:
> Hi Lucas,
> 
> On Mon, Feb 12, 2018 at 11:48:22AM +0100, Lucas Stach wrote:
> > Am Samstag, den 10.02.2018, 16:32 +0100 schrieb Stefan Agner:
> > > Add Dong Aisheng, Fabio Estevam, Shawn Guo and myself as
> > > maintainer
> > > and Sascha as reviewer.
> > > 
> > > Signed-off-by: Stefan Agner <stefan@...er.ch>
> > > ---
> > >  MAINTAINERS | 11 +++++++++++
> > >  1 file changed, 11 insertions(+)
> > > 
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 82ad0eabce4f..fb672dfc519d 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -10768,6 +10768,17 @@ L:	linux-gpio@...r.kernel.org
> > >  S:	Supported
> > >  F:	drivers/pinctrl/pinctrl-at91-pio4.*
> > >  
> > > +PIN CONTROLLER - FREESCALE
> > > +M:	Dong Aisheng <aisheng.dong@....com>
> > > +M:	Fabio Estevam <festevam@...il.com>
> > > +M:	Shawn Guo <shawnguo@...nel.org>
> > > +M:	Stefan Agner <stefan@...er.ch>
> > > +R:	Sascha Hauer <kernel@...gutronix.de>
> > 
> > I'm fine with the patch, but it might make sense to clarify this a
> > bit:
> > the kernel@ address is really the whole Pengutronix kernel team,
> > not
> > just Sascha. Using this address is totally fine if you expect
> > comments
> > on patches, as it gives them a quite wide exposure inside of PTX.
> 
> Of the 5 mentions of kernel@...gutronix.de in MAINTAINERS as of
> v4.16-rc1, 
> three name Sascha, and two name Uwe. Would you like to also clarify
> those?

I think it fine to keep the names of the individual people where they
maintain stuff, as this is usually bound to a single person (where
kernel@ address is only used for the exposure benefits), but I think it
makes less sense for the reviewer role.

Regards,
Lucas