linux-kernel - Re: [PATCH 1/2] staging: android: ion: Cleanup ion_page_pool_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <11ed8ba5-e6d2-1d36-cf8b-0eb19c6bcdb0@huawei.com>
Date:   Mon, 12 Feb 2018 19:41:16 +0800
From:   Yisheng Xie <xieyisheng1@...wei.com>
To:     <gregkh@...uxfoundation.org>, <labbott@...hat.com>
CC:     <devel@...verdev.osuosl.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] staging: android: ion: Cleanup
 ion_page_pool_alloc_pages

Hi Greg,

JFYI, I have rebase this patchset to v4.15-rc1.[1]

[1] https://lkml.org/lkml/2018/2/12/204

Thanks
Yisheng

On 2018/2/7 11:59, Yisheng Xie wrote:
> ion_page_pool_alloc_pages calls alloc_pages to allocate pages for page
> pools. If alloc_pages return NULL, it will return NULL, or it will
> return the pages allocate from alloc_pages. So we can just return
> alloc_pages without any judgement.
> 
> Signed-off-by: Yisheng Xie <xieyisheng1@...wei.com>
> ---
>  drivers/staging/android/ion/ion_page_pool.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/android/ion/ion_page_pool.c b/drivers/staging/android/ion/ion_page_pool.c
> index e3a6e32..6d2caf0 100644
> --- a/drivers/staging/android/ion/ion_page_pool.c
> +++ b/drivers/staging/android/ion/ion_page_pool.c
> @@ -11,13 +11,9 @@
>  
>  #include "ion.h"
>  
> -static void *ion_page_pool_alloc_pages(struct ion_page_pool *pool)
> +static inline struct page *ion_page_pool_alloc_pages(struct ion_page_pool *pool)
>  {
> -	struct page *page = alloc_pages(pool->gfp_mask, pool->order);
> -
> -	if (!page)
> -		return NULL;
> -	return page;
> +	return alloc_pages(pool->gfp_mask, pool->order);
>  }
>  
>  static void ion_page_pool_free_pages(struct ion_page_pool *pool,
>