linux-kernel - [tip:x86/pti] x86/mm/pti: Fix PTI comment in entry_SYSCALL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-14b1fcc62043729d12e8ae00f8297ab2ffe9fa91@git.kernel.org>
Date:   Sun, 11 Feb 2018 04:07:53 -0800
From:   tip-bot for Nadav Amit <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     hpa@...or.com, mingo@...nel.org, gregkh@...uxfoundation.org,
        arjan@...ux.intel.com, dwmw2@...radead.org,
        linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
        namit@...are.com, dave.hansen@...ux.intel.com,
        peterz@...radead.org, jpoimboe@...hat.com,
        dan.j.williams@...el.com, luto@...nel.org, bp@...en8.de,
        tglx@...utronix.de
Subject: [tip:x86/pti] x86/mm/pti: Fix PTI comment in entry_SYSCALL_64()

Commit-ID:  14b1fcc62043729d12e8ae00f8297ab2ffe9fa91
Gitweb:     https://git.kernel.org/tip/14b1fcc62043729d12e8ae00f8297ab2ffe9fa91
Author:     Nadav Amit <namit@...are.com>
AuthorDate: Fri, 9 Feb 2018 09:06:38 -0800
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Sat, 10 Feb 2018 12:44:51 +0100

x86/mm/pti: Fix PTI comment in entry_SYSCALL_64()

The comment is confusing since the path is taken when
CONFIG_PAGE_TABLE_ISOLATION=y is disabled (while the comment says it is not
taken).

Signed-off-by: Nadav Amit <namit@...are.com>
Cc: Andy Lutomirski <luto@...nel.org>
Cc: Arjan van de Ven <arjan@...ux.intel.com>
Cc: Borislav Petkov <bp@...en8.de>
Cc: Dan Williams <dan.j.williams@...el.com>
Cc: Dave Hansen <dave.hansen@...ux.intel.com>
Cc: David Woodhouse <dwmw2@...radead.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Josh Poimboeuf <jpoimboe@...hat.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: nadav.amit@...il.com
Link: http://lkml.kernel.org/r/20180209170638.15161-1-namit@vmware.com
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 arch/x86/entry/entry_64.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S
index 9e48002..932a445 100644
--- a/arch/x86/entry/entry_64.S
+++ b/arch/x86/entry/entry_64.S
@@ -213,7 +213,7 @@ ENTRY(entry_SYSCALL_64)
 
 	swapgs
 	/*
-	 * This path is not taken when PAGE_TABLE_ISOLATION is disabled so it
+	 * This path is only taken when PAGE_TABLE_ISOLATION is disabled so it
 	 * is not required to switch CR3.
 	 */
 	movq	%rsp, PER_CPU_VAR(rsp_scratch)