linux-kernel - Re: [PATCH] irqchip/irq-imx-gpcv2: Remove unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <287cdb39-92ed-79d7-82a0-69063e9d49e0@arm.com>
Date:   Mon, 12 Feb 2018 13:22:00 +0000
From:   Marc Zyngier <marc.zyngier@....com>
To:     Fabio Estevam <festevam@...il.com>, tglx@...utronix.de
Cc:     andrew.smirnov@...il.com, linux-kernel@...r.kernel.org,
        Fabio Estevam <fabio.estevam@....com>
Subject: Re: [PATCH] irqchip/irq-imx-gpcv2: Remove unused function

On 12/02/18 13:12, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@....com>
> 
> imx_gpcv2_get_wakeup_source() is not used anywhere, so remove it.
> 
> This fixes the following sparse warning:
> 
> drivers/irqchip/irq-imx-gpcv2.c:34:5: warning: symbol 'imx_gpcv2_get_wakeup_source' was not declared. Should it be static?
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@....com>
> ---
>  drivers/irqchip/irq-imx-gpcv2.c | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c
> index 675eda5..4760307 100644
> --- a/drivers/irqchip/irq-imx-gpcv2.c
> +++ b/drivers/irqchip/irq-imx-gpcv2.c
> @@ -28,20 +28,6 @@ struct gpcv2_irqchip_data {
>  
>  static struct gpcv2_irqchip_data *imx_gpcv2_instance;
>  
> -/*
> - * Interface for the low level wakeup code.
> - */
> -u32 imx_gpcv2_get_wakeup_source(u32 **sources)
> -{
> -	if (!imx_gpcv2_instance)
> -		return 0;
> -
> -	if (sources)
> -		*sources = imx_gpcv2_instance->wakeup_sources;
> -
> -	return IMR_NUM;
> -}
> -
>  static int gpcv2_wakeup_source_save(void)
>  {
>  	struct gpcv2_irqchip_data *cd;
> 

I'll queue this up for -rc2, with this addition:

Fixes: e324c4dc4a59 ("irqchip/imx-gpcv2: IMX GPCv2 driver for wakeup
sources")

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...