linux-kernel - Re: [PATCH -mm -v3] mm, swap, frontswap: Fix THP swap if frontswap enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180212022800.GA458@jagdpanzerIV>
Date:   Mon, 12 Feb 2018 11:28:00 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     "Huang, Ying" <ying.huang@...el.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org,
        Huang Ying <huang.ying.caritas@...il.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
        Dan Streetman <ddstreet@...e.org>,
        Seth Jennings <sjenning@...hat.com>,
        Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
        Shaohua Li <shli@...nel.org>, Michal Hocko <mhocko@...e.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Mel Gorman <mgorman@...hsingularity.net>,
        Shakeel Butt <shakeelb@...gle.com>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Juergen Gross <jgross@...e.com>, stable@...r.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Minchan Kim <minchan@...nel.org>
Subject: Re: [PATCH -mm -v3] mm, swap, frontswap: Fix THP swap if frontswap
 enabled

Hello,

On (02/09/18 13:03), Andrew Morton wrote:
[..]
> > Frontswap has multiple backends, to make it easy for one backend to
> > enable THP support, the THP checking is put in backend frontswap store
> > functions instead of the general interfaces.
> > 
> > Fixes: bd4c82c22c367e068 ("mm, THP, swap: delay splitting THP after swapped out")
> > Reported-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> > Tested-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> 
> I don't think Sergey has tested this version and I suspect this is a
> holdover from the earlier patch, so I'll remove this line.

Just tested it (v3) with FRONTSWAP enabled (didn't test XEN tmem).
Works fine.

FWIW
Tested-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com> # frontswap

	-ss