linux-kernel - Re: [PATCH v2 10/12] ARM: dts: STi: Add fake reg property for clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Feb 2018 09:22:55 -0600
From:   Rob Herring <rob.herring@...aro.org>
To:     patrice.chotard@...com
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>, linux@...linux.org.uk,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v2 10/12] ARM: dts: STi: Add fake reg property for clocks

On Mon, Feb 12, 2018 at 8:43 AM,  <patrice.chotard@...com> wrote:
> From: Patrice Chotard <patrice.chotard@...com>
>
> For all clock's element inside SoC, add a fake reg property,
> this allows to fix the following warnings when compiling
> dtb with W=1 option :
>
> arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
> Node /clocks/clk-m-a9-periphs missing or empty reg/ranges property
> arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
> Node /clocks/clk-m-a9-ext2f-div2s missing or empty reg/ranges property
> arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
> Node /clocks/clk-tmdsout-hdmi missing or empty reg/ranges property
>
> arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
> Node /clocks/clk-m-a9-periphs missing or empty reg/ranges property
> arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
> Node /clocks/clk-m-a9-ext2f-div2s missing or empty reg/ranges property
> arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
> Node /clocks/clk-tmdsout-hdmi missing or empty reg/ranges property
>
> arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
> Node /clocks/clk-m-a9-periphs missing or empty reg/ranges property
> arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
> Node /clocks/clk-m-a9-ext2f-div2s missing or empty reg/ranges property
> arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
> Node /clocks/clk-tmdsout-hdmi missing or empty reg/ranges property
>
> Signed-off-by: Patrice Chotard <patrice.chotard@...com>
> ---
>
> v2: _ add a fake reg property to node without reg property.
>
>  arch/arm/boot/dts/stih407-clock.dtsi | 9 ++++++---
>  arch/arm/boot/dts/stih410-clock.dtsi | 9 ++++++---
>  arch/arm/boot/dts/stih418-clock.dtsi | 9 ++++++---
>  3 files changed, 18 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stih407-clock.dtsi b/arch/arm/boot/dts/stih407-clock.dtsi
> index b882dcf3a649..1bba47e06ebe 100644
> --- a/arch/arm/boot/dts/stih407-clock.dtsi
> +++ b/arch/arm/boot/dts/stih407-clock.dtsi
> @@ -24,9 +24,10 @@
>                 /*
>                  * ARM Peripheral clock for timers
>                  */
> -               arm_periph_clk: clk-m-a9-periphs {
> +               arm_periph_clk: clk-m-a9-periphs@0 {
>                         #clock-cells = <0>;
>                         compatible = "fixed-factor-clock";
> +                       reg = <0 0>;

Don't do this. The correct fix is change the location of these nodes
to be under whatever controls them.

Rob