linux-kernel - Re: [PATCH net-next] trace_events_filter: conditional trace event (tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180212.113215.529432620125895990.davem@davemloft.net>
Date:   Mon, 12 Feb 2018 11:32:15 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     mhiramat@...nel.org
Cc:     mislam4@...t.edu, tom.zanussi@...ux.intel.com,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        stephen@...workplumber.org, mathieu.desnoyers@...ymtl.ca,
        rostedt@...dmis.org
Subject: Re: [PATCH net-next] trace_events_filter: conditional trace event
 (tcp_probe full=0)

From: Masami Hiramatsu <mhiramat@...nel.org>
Date: Tue, 13 Feb 2018 01:29:03 +0900

> On Mon, 12 Feb 2018 00:08:46 -0500
> "Md. Islam" <mislam4@...t.edu> wrote:
> 
>> Recently tcp_probe kernel module has been replaced by trace_event. Old
>> tcp_probe had full=0 option where it only takes a snapshot only when
>> congestion window is changed. However I did not find such
>> functionality in trace_event.
> 
> Yes, that seems broken to me. You should filter by using perf script or
> bpf. I'm not so clear about network stack, but it seems that cwnd can be
> set for each tcp connection. This means "current snd_cwnd" must be stored
> for each connection.

'bpf' is definitely the way to do custom stateful things like this.