linux-kernel - Re: [PATCH RESENT] nvme-pci: suspend queues based on online

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5011398b-8797-ece6-9df0-436c32aed33e@grimberg.me>
Date:   Mon, 12 Feb 2018 20:37:48 +0200
From:   Sagi Grimberg <sagi@...mberg.me>
To:     Jianchao Wang <jianchao.w.wang@...cle.com>, keith.busch@...el.com,
        axboe@...com, hch@....de
Cc:     linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESENT] nvme-pci: suspend queues based on online_queues


> nvme cq irq is freed based on queue_count. When the sq/cq creation
> fails, irq will not be setup. free_irq will warn 'Try to free
> already-free irq'.
> 
> To fix it, we only increase online_queues when adminq/sq/cq are
> created and associated irq is setup. Then suspend queues based
> on online_queues.
> 
> Signed-off-by: Jianchao Wang <jianchao.w.wang@...cle.com>

Can I get a review for this?