linux-kernel - Re: [PATCH v4 0/3] mtd: nand: vf610: fix error handling in vf610_nfc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180212223139.2e5404a9@bbrezillon>
Date:   Mon, 12 Feb 2018 22:31:39 +0100
From:   Boris Brezillon <boris.brezillon@...tlin.com>
To:     Alexey Khoroshilov <khoroshilov@...ras.ru>
Cc:     Boris Brezillon <boris.brezillon@...e-electrons.com>,
        ldv-project@...uxtesting.org, Richard Weinberger <richard@....at>,
        linux-kernel@...r.kernel.org, Stefan Agner <stefan@...er.ch>,
        linux-mtd@...ts.infradead.org
Subject: Re: [PATCH v4 0/3] mtd: nand: vf610: fix error handling in
 vf610_nfc_probe()

On Sat, 10 Feb 2018 01:28:33 +0300
Alexey Khoroshilov <khoroshilov@...ras.ru> wrote:

> vf610_nfc_probe() misses error handling of mtd_device_register()
> and contains unneeded of_node_put() on error path.

Applied the whole series.

Thanks,

Boris

> 
> v2: Add nand_cleanup() to undone nand_scan_tail() as Boris Brezillon noted.
> v3: Rename error labels, remove of_node_put() per Boris Brezillon request.
> v4: Separate fix in to 3 patches.
> 
> Alexey Khoroshilov (3):
>   mtd: nand: vf610: remove the unnecessary of_node_put()
>   mtd: nand: vf610: improve readability of error label
>   mtd: nand: vf610: check mtd_device_register() return code
> 
>  drivers/mtd/nand/vf610_nfc.c | 29 ++++++++++++++++-------------
>  1 file changed, 16 insertions(+), 13 deletions(-)
> 



-- 
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com