lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 Feb 2018 23:18:47 +0000 From: Alan Cox <gnomes@...rguk.ukuu.org.uk> To: Thomas Gleixner <tglx@...utronix.de> Cc: "Gustavo A. R. Silva" <garsilva@...eddedor.com>, Borislav Petkov <bp@...en8.de>, Ingo Molnar <mingo@...hat.com>, "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] x86/microcode/intel: Use 64-bit arithmetic instead of 32-bit > if (c->x86_cache_size >= 0) > seq_printf(m, "cache size\t: %d KB\n", c->x86_cache_size); > > which is silly, because that really can be done with: > > if (c->x86_cache_size) > > as there is no point in printing 'cache size 0KB', which means > x86_cache_size can be made unsigned int, which makes sense because cache > size < 0 does not at all. Currently 0MB means "I know you have no cache" (early slot 1 celeron), while not printing it means 'I have no clue' Alan
Powered by blists - more mailing lists