linux-kernel - Re: [PATCH] Revert "ARM: dts: sunxi: Add regulators for Sinovoip BPI-M2"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180213103013.37q3pg6cedxur4qp@flea.lan>
Date:   Tue, 13 Feb 2018 11:30:13 +0100
From:   Maxime Ripard <maxime.ripard@...tlin.com>
To:     Emmanuel Vadot <manu@...ouilliste.com>
Cc:     Icenowy Zheng <icenowy@...c.io>, devicetree@...r.kernel.org,
        linux-sunxi@...glegroups.com, linux-kernel@...r.kernel.org,
        Chen-Yu Tsai <wens@...e.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] Revert "ARM: dts: sunxi: Add regulators for Sinovoip
 BPI-M2"

On Fri, Feb 09, 2018 at 10:20:57PM +0100, Emmanuel Vadot wrote:
> > P.S. a proper device tree with AXP shouldn't use
> > reg_vcc3v0/3v3/1v8/etc. They're dummy
> > regulator nodes for
> > not implemented or not controllable regulators.
> > 
> > > 
> > > > This indicates that this patch should be not tested at all.
> > > 
> > > This have indeed not been tested with linux.
> > > I think that this commit should not be reverted, I'll send a proper
> > > patch tonight or tomorow night max.
> > 
> > Please test patches sent to Linux on Linux :-)
> 
>  If my patches adhere to the bindings I don't see why.

Adhering to a binding and being functional is a completely different
story.

And the latter is the most important.

Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)