linux-kernel - Re: [PATCH] kernel/sched/cpudeadline: Fixed code style errors and warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180213122742.tz2j5nkwuopi7unp@gmail.com>
Date:   Tue, 13 Feb 2018 13:27:42 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Mario Leinweber <marioleinweber@....de>
Cc:     mingo@...hat.com, peterz@...radead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel/sched/cpudeadline: Fixed code style errors and
 warnings


* Mario Leinweber <marioleinweber@....de> wrote:

> diff --git a/kernel/sched/cpudeadline.c b/kernel/sched/cpudeadline.c
> index 8d9562d890d3..6a9defebbb54 100644
> --- a/kernel/sched/cpudeadline.c
> +++ b/kernel/sched/cpudeadline.c
> @@ -42,8 +42,9 @@ static void cpudl_heapify_down(struct cpudl *cp, int idx)
>  		return;
>  
>  	/* adapted from lib/prio_heap.c */
> -	while(1) {
> +	while (1) {
>  		u64 largest_dl;
> +
>  		l = left_child(idx);
>  		r = right_child(idx);
>  		largest = idx;
> @@ -131,6 +132,7 @@ int cpudl_find(struct cpudl *cp, struct task_struct *p,
>  		return 1;
>  	} else {
>  		int best_cpu = cpudl_maximum(cp);
> +
>  		WARN_ON(best_cpu != -1 && !cpu_present(best_cpu));
>  
>  		if (cpumask_test_cpu(best_cpu, &p->cpus_allowed) &&
> @@ -205,6 +207,7 @@ void cpudl_set(struct cpudl *cp, int cpu, u64 dl)
>  	old_idx = cp->elements[cpu].idx;
>  	if (old_idx == IDX_INVALID) {
>  		int new_idx = cp->size++;
> +
>  		cp->elements[new_idx].dl = dl;
>  		cp->elements[new_idx].cpu = cpu;
>  		cp->elements[cpu].idx = new_idx;

Your Signed-off-by tag is missing.

Thanks,

	Ingo