linux-kernel - Re: [PATCH v2] power: reset: Add Spreadtrum SC27xx PMIC power off support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180213124810.oyf4ec5bpbnsnkqy@earth.universe>
Date:   Tue, 13 Feb 2018 13:48:10 +0100
From:   Sebastian Reichel <sre@...nel.org>
To:     Baolin Wang <baolin.wang@...aro.org>
Cc:     arnd@...db.de, broonie@...nel.org, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH v2] power: reset: Add Spreadtrum SC27xx PMIC power off
 support

Hi Baolin,

On Fri, Feb 09, 2018 at 01:30:44PM +0100, Sebastian Reichel wrote:
> On Fri, Feb 09, 2018 at 05:43:38PM +0800, Baolin Wang wrote:
> > On Spreadtrum platform, we need power off system through external SC27xx
> > series PMICs including the SC2720, SC2721, SC2723, SC2730 and SC2731 chips.
> > Thus this patch adds SC27xx series PMICs power-off support.
> > 
> > Signed-off-by: Baolin Wang <baolin.wang@...aro.org>
> 
> Thanks, queued. My public -next branch is waiting for 4.16-rc1,
> though.

I just dropped this patch. It does not compile as a module:

ERROR: "freeze_secondary_cpus" [drivers/power/reset/sc27xx-poweroff.ko] undefined!

There is no EXPORT_SYMBOL for freeze_secondary_cpus, so you either
need to add that or make the new driver built-in only.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)