linux-kernel - Re: [PATCH v2 09/12] ARM: dts: STi: Add fake reg property for sound related nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99afc3f9-d0b4-b13c-ac97-4347f25aa000@st.com>
Date:   Tue, 13 Feb 2018 12:54:56 +0000
From:   Patrice CHOTARD <patrice.chotard@...com>
To:     Rob Herring <robh@...nel.org>
CC:     Mark Rutland <mark.rutland@....com>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v2 09/12] ARM: dts: STi: Add fake reg property for sound
 related nodes

Hi Rob

On 02/12/2018 04:40 PM, Rob Herring wrote:
> On Mon, Feb 12, 2018 at 8:43 AM,  <patrice.chotard@...com> wrote:
>> From: Patrice Chotard <patrice.chotard@...com>
>>
>> Add fake reg property to sound, simple-audio-card, dai-link and
>> sti_sasg_codec nodes, this allows to fix the following warning
>> when compiling dtb with W=1 option:
>>
>> arch/arm/boot/dts/stih407-b2120.dtb: Warning (unit_address_vs_reg):
>> Node /soc/sound/simple-audio-card,dai-link@0 has a unit name, but no reg property
>> arch/arm/boot/dts/stih407-b2120.dtb: Warning (unit_address_vs_reg):
>> Node /soc/sound/simple-audio-card,dai-link@1 has a unit name, but no reg property
>> arch/arm/boot/dts/stih407-b2120.dtb: Warning (unit_address_vs_reg):
>> Node /soc/sound/simple-audio-card,dai-link@2 has a unit name, but no reg property
>> arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
>> Node /soc/sti-sasg-codec missing or empty reg/ranges property
>>
>> arch/arm/boot/dts/stih410-b2120.dtb: Warning (unit_address_vs_reg):
>> Node /soc/sound/simple-audio-card,dai-link@0 has a unit name, but no reg property
>> arch/arm/boot/dts/stih410-b2120.dtb: Warning (unit_address_vs_reg):
>> Node /soc/sound/simple-audio-card,dai-link@1 has a unit name, but no reg property
>> arch/arm/boot/dts/stih410-b2120.dtb: Warning (unit_address_vs_reg):
>> Node /soc/sound/simple-audio-card,dai-link@2 has a unit name, but no reg property
>> arch/arm/boot/dts/stih407-b2120.dtb: Warning (simple_bus_reg):
>> Node /soc/sound missing or empty reg/ranges property
>> arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg):
>> Node /soc/sti-sasg-codec missing or empty reg/ranges property
>>
>> arch/arm/boot/dts/stih410-b2260.dtb: Warning (unit_address_vs_reg):
>> Node /soc/sound/simple-audio-card,dai-link@0 has a unit name, but no reg property
>> arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
>> Node /soc/sti-sasg-codec missing or empty reg/ranges property
>> arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg):
>> Node /soc/sound missing or empty reg/ranges property
>>
>> arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg):
>> Node /soc/sti-sasg-codec missing or empty reg/ranges property
>>
>> Signed-off-by: Patrice Chotard <patrice.chotard@...com>
>> ---
>>
>> v2: _ add a fake reg property to node without reg property.
>>
>>   arch/arm/boot/dts/stih407-family.dtsi |  3 ++-
>>   arch/arm/boot/dts/stih410-b2260.dts   |  5 +++--
>>   arch/arm/boot/dts/stihxxx-b2120.dtsi  | 11 ++++++-----
>>   3 files changed, 11 insertions(+), 8 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
>> index 5df827b00eb6..df1a3f1dc5a7 100644
>> --- a/arch/arm/boot/dts/stih407-family.dtsi
>> +++ b/arch/arm/boot/dts/stih407-family.dtsi
>> @@ -894,8 +894,9 @@
>>                          status = "disabled";
>>                  };
>>
>> -               sti_sasg_codec: sti-sasg-codec {
>> +               sti_sasg_codec: sti-sasg-codec@0 {
>>                          compatible = "st,stih407-sas-codec";
>> +                       reg = <0 0>;
>>                          #sound-dai-cells = <1>;
>>                          status = "disabled";
>>                          st,syscfg = <&syscfg_core>;
> 
> This should probably be a child of syscfg to fix this. And if this
> block has a dedicated set of registers, then use reg to define those
> (even though regmap/syscon doesn't need it).

Ok, i will mode this node

> 
>> diff --git a/arch/arm/boot/dts/stih410-b2260.dts b/arch/arm/boot/dts/stih410-b2260.dts
>> index 8bcd58118dba..03d05a98b7fc 100644
>> --- a/arch/arm/boot/dts/stih410-b2260.dts
>> +++ b/arch/arm/boot/dts/stih410-b2260.dts
>> @@ -181,12 +181,13 @@
>>                          status = "okay";
>>                  };
>>
>> -               sound {
>> +               sound: sound@0 {
> 
> I'd move this up to top level.

Ok

Thanks

Patrice



> 
> Rob
>