linux-kernel - Re: [PATCH v2 08/15] MIPS: memblock: Mark present sparsemem sections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e6f3afd-6413-2fc7-4c23-a272cb9e19ff@mips.com>
Date:   Tue, 13 Feb 2018 13:50:14 +0000
From:   Matt Redfearn <matt.redfearn@...s.com>
To:     Serge Semin <fancer.lancer@...il.com>, <ralf@...ux-mips.org>,
        <miodrag.dinic@...s.com>, <jhogan@...nel.org>,
        <goran.ferenc@...s.com>, <david.daney@...ium.com>,
        <paul.gortmaker@...driver.com>, <paul.burton@...s.com>,
        <alex.belits@...ium.com>, <Steven.Hill@...ium.com>
CC:     <alexander.sverdlin@...ia.com>, <kumba@...too.org>,
        <marcin.nowakowski@...s.com>, <James.hogan@...s.com>,
        <Peter.Wotton@...s.com>, <Sergey.Semin@...latforms.ru>,
        <linux-mips@...ux-mips.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 08/15] MIPS: memblock: Mark present sparsemem sections

Hi Serge,


On 02/02/18 03:54, Serge Semin wrote:
> If sparsemem is activated all sections with present pages must
> be accordingly marked after memblock is fully initialized.
> 
> Signed-off-by: Serge Semin <fancer.lancer@...il.com>
> ---
>   arch/mips/kernel/setup.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
> index b2a5b89ae6b2..54302319ce1c 100644
> --- a/arch/mips/kernel/setup.c
> +++ b/arch/mips/kernel/setup.c
> @@ -837,6 +837,11 @@ static void __init arch_mem_init(char **cmdline_p)
>   				 crashk_res.end - crashk_res.start + 1);
>   #endif
>   	device_tree_init();
> +#ifdef CONFIG_SPARSEMEM
> +	for_each_memblock(memory, reg)
> +		memory_present(0, memblock_region_memory_base_pfn(reg),
> +				memblock_region_memory_end_pfn(reg));
> +#endif /* CONFIG_SPARSEMEM */


Existing code calls memory_present without CONFIG_SPARSEMEM, is it 
really conditional on SPARSEMEM?

Thanks,
Matt

>   	sparse_init();
>   	plat_swiotlb_setup();
>   
>