linux-kernel - Re: [PATCH] fs/signalfd: fix build error for BUS_MCEERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tvul4opx.fsf@xmission.com>
Date:   Mon, 12 Feb 2018 20:18:02 -0600
From:   ebiederm@...ssion.com (Eric W. Biederman)
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Linux FS Devel <linux-fsdevel@...r.kernel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH] fs/signalfd: fix build error for BUS_MCEERR_AR

Randy Dunlap <rdunlap@...radead.org> writes:

> From: Randy Dunlap <rdunlap@...radead.org>
>
> Fix build error in fs/signalfd.c by using same method that is used in
> kernel/signal.c: separate blocks for different signal si_code values.
>
> ./fs/signalfd.c: error: 'BUS_MCEERR_AR' undeclared (first use in this function)
>
> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Eric Biederman <ebiederm@...ssion.com>
> Cc: Alexander Viro <viro@...iv.linux.org.uk>

Acked-by: "Eric W. Biederman" <ebiederm@...ssion.com>

Do you want to me to pick this one up?  Or does it have another path
into mainline?

Eric

> ---
>  fs/signalfd.c |   15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
>
> Applies to mainline 4.16-rc1.
>
> --- linux-next-20180212.orig/fs/signalfd.c
> +++ linux-next-20180212/fs/signalfd.c
> @@ -118,13 +118,22 @@ static int signalfd_copyinfo(struct sign
>  		err |= __put_user(kinfo->si_trapno, &uinfo->ssi_trapno);
>  #endif
>  #ifdef BUS_MCEERR_AO
> -		/* 
> +		/*
>  		 * Other callers might not initialize the si_lsb field,
>  		 * so check explicitly for the right codes here.
>  		 */
>  		if (kinfo->si_signo == SIGBUS &&
> -		    (kinfo->si_code == BUS_MCEERR_AR ||
> -		     kinfo->si_code == BUS_MCEERR_AO))
> +		     kinfo->si_code == BUS_MCEERR_AO)
> +			err |= __put_user((short) kinfo->si_addr_lsb,
> +					  &uinfo->ssi_addr_lsb);
> +#endif
> +#ifdef BUS_MCEERR_AR
> +		/*
> +		 * Other callers might not initialize the si_lsb field,
> +		 * so check explicitly for the right codes here.
> +		 */
> +		if (kinfo->si_signo == SIGBUS &&
> +		    kinfo->si_code == BUS_MCEERR_AR)
>  			err |= __put_user((short) kinfo->si_addr_lsb,
>  					  &uinfo->ssi_addr_lsb);
>  #endif