linux-kernel - Re: move stack-protector availability out of Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP8WD_Yr8bt+uz7JBixf+xELB-_3Y8J8tsaQWpEg8nvFtGFraw@mail.gmail.com>
Date:   Tue, 13 Feb 2018 10:27:29 -0500
From:   tedheadster <tedheadster@...il.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     akpm@...ux-foundation.org, yamada.masahiro@...ionext.com,
        Arnd Bergmann <arnd@...db.de>, josh@...htriplett.org,
        npiggin@...il.com, Laura Abbott <labbott@...hat.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: move stack-protector availability out of Kconfig

Kees,
  I have a question about this patch. When I configure a kernel for
ARCH=i386 it sets these Kconfig variables this way:

HAVE_CC_STACKPROTECTOR=y
CC_STACKPROTECTOR_AUTO=y

CC_STACKPROTECTOR_NONE=n
CC_STACKPROTECTOR_REGULAR=n
CC_STACKPROTECTOR_STRONG=n

It seems to me that at least _one_ of the last _three_ variables
should be set to 'y' with the defaults that are being set, probably
CC_STACKPOINTER_NONE=y. All of them being 'n' doesn't make sense to
me.

As a side note, these defaults set X86_32_LAZY_GS=n (depends on X86_32
[=y] && CC_STACKPROTECTOR_NONE [=n]) which causes the x86_32 kernels
to hang. I'll discuss  that in a different email thread, but just
wanted to say how I came upon this.

- Matthew Whitehead