linux-kernel - Re: [PATCH] iommu/amd - Use dev_err to send events to the system log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <325d7406-e01b-f7a1-3da6-390b0cf9bc94@amd.com>
Date:   Tue, 13 Feb 2018 10:47:55 -0500
From:   "Hook, Gary" <ghook@....com>
To:     Joerg Roedel <joro@...tes.org>, Gary R Hook <gary.hook@....com>
Cc:     iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu/amd - Use dev_err to send events to the system log

On 2/13/2018 8:22 AM, Joerg Roedel wrote:
> On Tue, Jan 30, 2018 at 07:04:27PM -0600, Gary R Hook wrote:
>> +		dev_err(dev, "ILLEGAL_DEV_TABLE_ENTRY device=%02x:%02x.%x "
>> +			"address=0x%016llx flags=0x%04x]\n",
>> +			PCI_BUS_NUM(devid), PCI_SLOT(devid), PCI_FUNC(devid),
>> +			address, flags);
> 
> That prints the PCI device-name of the IOMMU in front of the message. Is
> that actually helpful?
> 
> If at all, we should print the name of the iommu-device in front of the
> message, not the PCI device that hosts the IOMMU.

so (e.g.):

         dev_err(&iommu->dev->dev, "ILLEGAL...

?

I'm okay with that. It does make more sense.

Gary