linux-kernel - Re: [RFC PATCH 0/8] tracing: probeevent: Improve fetcharg features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180213105820.3e0581a0@gandalf.local.home>
Date:   Tue, 13 Feb 2018 10:58:20 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Tom Zanussi <tom.zanussi@...ux.intel.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        linux-trace-users@...r.kernel.org
Subject: Re: [RFC PATCH 0/8] tracing: probeevent: Improve fetcharg features

On Wed, 14 Feb 2018 00:35:45 +0900
Masami Hiramatsu <mhiramat@...nel.org> wrote:

> Hi,
> 
> This series improves probeevent variable fetcharg framework,
> 
> - Rewrite fetcharg framework with fetch_insn, switch-case based
>   instead of function pointer. (maybe good for retpoline)
> - Add "symbol" type support, which shows symbol+offset instead of
>   address value.
> - Add "$argN" fetcharg, which fetches function parameters.
>   (currently only for x86-64)
> - Add array type support for basic types (except for string),
>   which enables to get fixed length array from probeevents.
> 
> All ideas came from Steve's function event tracer. Thanks Steve!

You're welcome ;-)

> 
> I'll add string (pointer) array support and testcases for these
> features in the next version.
> 

Just to let you know I'm trying to catch up with some internal work and
may not be able to look at these for a few days.

Hopefully others will be able to review them.

-- Steve