linux-kernel - [PATCH] efi/apple-properties: Delete an error message for a failed memory allocation in unmarshal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <145f8fac-9297-b362-d89f-886632e2507f@users.sourceforge.net>
Date:   Tue, 13 Feb 2018 18:00:26 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     linux-efi@...r.kernel.org,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: [PATCH] efi/apple-properties: Delete an error message for a failed
 memory allocation in unmarshal_devices()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Tue, 13 Feb 2018 17:52:10 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/firmware/efi/apple-properties.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/firmware/efi/apple-properties.c b/drivers/firmware/efi/apple-properties.c
index 9f6bcf173b0e..f5f3159df4d5 100644
--- a/drivers/firmware/efi/apple-properties.c
+++ b/drivers/firmware/efi/apple-properties.c
@@ -158,10 +158,8 @@ static int __init unmarshal_devices(struct properties_header *properties)
 
 		entry = kcalloc(dev_header->prop_count + 1, sizeof(*entry),
 				GFP_KERNEL);
-		if (!entry) {
-			dev_err(dev, "cannot allocate properties\n");
+		if (!entry)
 			goto skip_device;
-		}
 
 		unmarshal_key_value_pairs(dev_header, dev, ptr, entry);
 		if (!entry[0].name)
-- 
2.16.1