linux-kernel - Re: [PATCH v2 04/11] watchdog/hpwdt: white space changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180213174449.GB22401@roeck-us.net>
Date:   Tue, 13 Feb 2018 09:44:49 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Philippe Ombredanne <pombredanne@...b.com>
Cc:     Jerry Hoemann <jerry.hoemann@....com>, wim@...ux-watchdog.org,
        linux-watchdog@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>, rwright@....com,
        maurice.a.saldivar@....com
Subject: Re: [PATCH v2 04/11] watchdog/hpwdt: white space changes

On Mon, Feb 12, 2018 at 10:35:50AM +0100, Philippe Ombredanne wrote:
> Jerry,
> 
> On Mon, Feb 12, 2018 at 6:21 AM, Jerry Hoemann <jerry.hoemann@....com> wrote:
> > Minor white space changes and some name clean up.
> >
> > Signed-off-by: Jerry Hoemann <jerry.hoemann@....com>
> > ---
> >  drivers/watchdog/hpwdt.c | 49 +++++++++++++++++++++++-------------------------
> >  1 file changed, 23 insertions(+), 26 deletions(-)
> >
> > diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
> > index 6f7949ef9a23..ee9a92220ece 100644
> > --- a/drivers/watchdog/hpwdt.c
> > +++ b/drivers/watchdog/hpwdt.c
> > @@ -1,11 +1,9 @@
> >  /*
> >   *     HPE WatchDog Driver
> > - *     based on
> >   *
> > - *     SoftDog 0.05:   A Software Watchdog Device
> > - *
> > - *     (c) Copyright 2015 Hewlett Packard Enterprise Development LP
> > + *     (c) Copyright 2018 Hewlett Packard Enterprise Development LP
> >   *     Thomas Mingarelli <thomas.mingarelli@....com>
> > + *     Jerry Hoemann <jerry.hoemann@....com>
> >   *
> >   *     This program is free software; you can redistribute it and/or
> >   *     modify it under the terms of the GNU General Public License
> 
> Since you are updating the copyright, why not updating the licensing
> to use the new concise SPDX ids instead? [1]
> And you get a big good karma bonus if you can also do the same for all
> HPE-copyrighted files, tree-wide ;) and/or spread the word inside your
> team.
> 

Different logical change, separate patch, please. Which, on a side note,
you might consider submitting yourself.

Thanks,
Guenter