linux-kernel - Re: [PATCH v2 10/11] watchdog/hpwdt: remove allow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180213182042.GA26558@roeck-us.net>
Date:   Tue, 13 Feb 2018 10:20:42 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Jerry Hoemann <jerry.hoemann@....com>
Cc:     wim@...ux-watchdog.org, linux-watchdog@...r.kernel.org,
        linux-kernel@...r.kernel.org, rwright@....com,
        maurice.a.saldivar@....com
Subject: Re: [PATCH v2 10/11] watchdog/hpwdt: remove allow_kdump module
 parameter.

On Sun, Feb 11, 2018 at 10:21:10PM -0700, Jerry Hoemann wrote:
> The intent of this parameter is unclear and it sets up a
> race between the reset of the system by ASR and crashdump.
> 
> The length of time between receipt of the pretimeout NMI
> and the ASR reset of the system is fixed by hardware.
> 
> Turning the parameter off doesn't necessairly prevent a crash dump.
> Also, having the ASR reset occur while the system is crash dumping
> doesn't imply that the dump was hung given the short duration
> between the NMI and the reset.
> 
> This parameter is not a substitute for having a architected watchdog
> crashdump hang detection paridigm.
> 
> Signed-off-by: Jerry Hoemann <jerry.hoemann@....com>
> ---
>  drivers/watchdog/hpwdt.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
> index e9e54fe20804..bb0dcc8709b8 100644
> --- a/drivers/watchdog/hpwdt.c
> +++ b/drivers/watchdog/hpwdt.c
> @@ -33,7 +33,6 @@
>  static unsigned int soft_margin = DEFAULT_MARGIN;	/* in seconds */
>  static bool nowayout = WATCHDOG_NOWAYOUT;
>  #ifdef CONFIG_HPWDT_NMI_DECODING
> -static unsigned int allow_kdump = 1;

At the end of hpwdt_init_nmi_decoding(), there used to be a log message
showing the value of allow_kdump. Maybe that was removed in another patch,
but it really belongs to this patch, or am I missing something ?

Guenter

>  static bool pretimeout = 1;
>  #else
>  static bool pretimeout;
> @@ -149,8 +148,7 @@ static int hpwdt_pretimeout(unsigned int ulReason, struct pt_regs *regs)
>  	if (iLO5 && (ulReason == NMI_UNKNOWN) && !mynmi)
>  		return NMI_DONE;
>  
> -	if (allow_kdump)
> -		hpwdt_stop(&hpwdt_dev);
> +	hpwdt_stop(&hpwdt_dev);
>  
>  	panic_msg[0] = hexdigit((mynmi>>4)&0xf);
>  	panic_msg[1] = hexdigit(mynmi&0xf);
> @@ -351,9 +349,6 @@ MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default="
>  		__MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
>  
>  #ifdef CONFIG_HPWDT_NMI_DECODING	/* { */
> -module_param(allow_kdump, int, 0444);
> -MODULE_PARM_DESC(allow_kdump, "Start a kernel dump after NMI occurs");
> -
>  module_param(pretimeout, bool, 0444);
>  MODULE_PARM_DESC(pretimeout, "Watchdog pretimeout enabled");
>  #endif					/* } */
> -- 
> 2.13.6
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html