linux-kernel - Re: [PATCH v2 0/2] Add support for AK4458 DAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 13 Feb 2018 20:32:23 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Cosmin-Gabriel Samoila <cosmin.samoila@....com>
Cc:     Mark Brown <broonie@...nel.org>,
        ALSA Development Mailing List <alsa-devel@...a-project.org>,
        devicetree <devicetree@...r.kernel.org>,
        Rob Herring <robh@...nel.org>,
        Mihai Serban <mihai.serban@...il.com>,
        dl-linux-imx <linux-imx@....com>, shegjiu.wang@....com,
        Daniel Baluta <daniel.baluta@....com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 0/2] Add support for AK4458 DAC

On Tue, Feb 13, 2018 at 4:14 PM, Cosmin-Gabriel Samoila
<cosmin.samoila@....com> wrote:
> We support Normal Mode, TDM Mode and PM.
>

Read the comments Mark and me gave against another [1] submission.

[1]: https://www.spinics.net/lists/alsa-devel/msg73471.html

> Changes since V1:
> - support only i2c
> - i2c probe / remove/suspend/ resume moved into shared code
> - change enum array to separate variables
> - aggregate Volume control for Left and Right Channel
> - remove mux from DAPM
> - remove unused functions
> - remove unused controls
> - remove unused macros
> - use snd_soc_update_bits instead of soc_read + soc_write
> - use GPIOD
> - use SPDX identifier
> - use dac@10 instgitead of ak4458@10
> - use explicit power_on/off functions
> - add __maybe_unused attribute
> - use probe_new for i2c_probe
>
> Cosmin-Gabriel Samoila (2):
>   ASoC: codecs: Add support for AK4458 DAC driver
>   ASoC: ak4458: Add bindings for AK4458 DAC
>
>  Documentation/devicetree/bindings/sound/ak4458.txt |  23 +
>  sound/soc/codecs/Kconfig                           |   6 +
>  sound/soc/codecs/Makefile                          |   2 +
>  sound/soc/codecs/ak4458.c                          | 684 +++++++++++++++++++++
>  sound/soc/codecs/ak4458.h                          |  75 +++
>  5 files changed, 790 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/ak4458.txt
>  create mode 100644 sound/soc/codecs/ak4458.c
>  create mode 100644 sound/soc/codecs/ak4458.h
>
> --
> 2.7.4
>



-- 
With Best Regards,
Andy Shevchenko