linux-kernel - [PATCH 1/2] firewire: nosy: Delete an error message for a failed memory allocation in add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0b5d64ea-8305-de22-7fa7-e878045104ec@users.sourceforge.net>
Date:   Tue, 13 Feb 2018 19:33:59 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     linux1394-devel@...ts.sourceforge.net,
        Stefan Richter <stefanr@...6.in-berlin.de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: [PATCH 1/2] firewire: nosy: Delete an error message for a failed
 memory allocation in add_card()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Tue, 13 Feb 2018 18:33:45 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/firewire/nosy.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/firewire/nosy.c b/drivers/firewire/nosy.c
index fee2e9e7ea20..6192f0718bf2 100644
--- a/drivers/firewire/nosy.c
+++ b/drivers/firewire/nosy.c
@@ -553,7 +553,6 @@ add_card(struct pci_dev *dev, const struct pci_device_id *unused)
 
 	lynx = kzalloc(sizeof *lynx, GFP_KERNEL);
 	if (lynx == NULL) {
-		dev_err(&dev->dev, "Failed to allocate control structure\n");
 		ret = -ENOMEM;
 		goto fail_disable;
 	}
-- 
2.16.1