linux-kernel - Re: [2/2] powerpc/pseries: Declare optional dummy function for find_and_online_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <3zh7ch49bHz9t6D@ozlabs.org>
Date:   Wed, 14 Feb 2018 16:43:48 +1100 (AEDT)
From:   Michael Ellerman <patch-notifications@...erman.id.au>
To:     Guenter Roeck <linux@...ck-us.net>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:     linux-kernel@...r.kernel.org,
        Michael Bringmann <mwb@...ux.vnet.ibm.com>,
        Paul Mackerras <paulus@...ba.org>,
        Nathan Fontenot <nfont@...ux.vnet.ibm.com>,
        linuxppc-dev@...ts.ozlabs.org, Guenter Roeck <linux@...ck-us.net>
Subject: Re: [2/2] powerpc/pseries: Declare optional dummy function for find_and_online_cpu_nid

On Mon, 2018-02-12 at 22:34:08 UTC, Guenter Roeck wrote:
> Commit e67e02a544e9 ("powerpc/pseries: Fix cpu hotplug crash with
> memoryless nodes") adds an unconditional call to find_and_online_cpu_nid(),
> which is only declared if CONFIG_PPC_SPLPAR is enabled. This results in
> the following build error if this is not the case.
> 
> arch/powerpc/platforms/pseries/hotplug-cpu.o: In function `dlpar_online_cpu':
> arch/powerpc/platforms/pseries/hotplug-cpu.c:369:
> 			undefined reference to `.find_and_online_cpu_nid'
> 
> Follow the guideline provided by similar functions and provide a dummy
> function if CONFIG_PPC_SPLPAR is not enabled. This also moves the external
> function declaration into an include file where it should be.
> 
> Fixes: e67e02a544e9 ("powerpc/pseries: Fix cpu hotplug crash with ...")
> Cc: Michael Bringmann <mwb@...ux.vnet.ibm.com>
> Cc: Michael Ellerman <mpe@...erman.id.au>
> Cc: Nathan Fontenot <nfont@...ux.vnet.ibm.com>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

Applied to powerpc fixes, thanks.

https://git.kernel.org/powerpc/c/82343484a2d4c97a03bfd81303b549

cheers