linux-kernel - RE: clang asm-goto support (Was Re: [PATCH v2] x86/retpoline: Add clang support)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A3D6595E4CE1DA4A80538CC077C51A2B84771900@hasmsx107.ger.corp.intel.com>
Date:   Wed, 14 Feb 2018 09:52:59 +0000
From:   "Yatsina, Marina" <marina.yatsina@...el.com>
To:     Peter Zijlstra <peterz@...radead.org>
CC:     Kees Cook <keescook@...gle.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Chandler Carruth <chandlerc@...gle.com>,
        "Kreitzer, David L" <david.l.kreitzer@...el.com>,
        "Grischenko, Andrei L" <andrei.l.grischenko@...el.com>,
        "rnk@...gle.com" <rnk@...gle.com>,
        "LLVM Developers" <llvm-dev@...ts.llvm.org>,
        "ehsan@...illa.com" <ehsan@...illa.com>,
        "Tayree, Coby" <coby.tayree@...el.com>,
        Matthias Braun <matze@...unis.de>,
        Dean Michael Berris <dean.berris@...il.com>,
        "James Y Knight" <jyknight@...gle.com>,
        Guenter Roeck <linux@...ck-us.net>, X86 ML <x86@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Alan Cox <gnomes@...rguk.ukuu.org.uk>,
        Rik van Riel <riel@...hat.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Tom Lendacky <thomas.lendacky@....com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Jiri Kosina <jikos@...nel.org>,
        Andy Lutomirski <luto@...capital.net>,
        "Hansen, Dave" <dave.hansen@...el.com>,
        Tim Chen <tim.c.chen@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...ux-foundation.org>,
        Paul Turner <pjt@...gle.com>,
        Stephen Hines <srhines@...gle.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>
Subject: RE: clang asm-goto support (Was Re: [PATCH v2] x86/retpoline: Add
 clang support)

Hi Peter,

When I started the original thread last year I was in favor of adding "asm goto" and didn't understand why it wasn't done by that time.
The feedback I got is that this feature (optimizing tracepoints) is very useful and that we do want it in llvm, but perhaps there's a cleaner way of implementing than "asm goto". An alternative suggestion arose as well. 

I'm sure you can provide a lot of background for the decisions of why "asm goto" was chosen and which other alternatives were considered, as you were the one to implement this. This may shed a lot of light on the alternative suggestions that arose in my thread in the llvm community.
I think that including GCC folks in the "small team" discussion Chandler suggested might be a very good idea, so if you have some contacts, please send them to Chandler.

Anyway, I think we should consider the alternatives and not take "asm goto" as a given, even though this is the implementation of this feature for the past 7 years and it works well.
I'm not saying linux kernel needs to rush and adopt an alternative solution ASAP, but we cannot ignore that it exists and may (or may not) be the direction of the future (for both gcc and llvm).

Thanks,
Marina

-----Original Message-----
From: Peter Zijlstra [mailto:peterz@...radead.org] 
Sent: Wednesday, February 14, 2018 11:09
To: Yatsina, Marina <marina.yatsina@...el.com>
Cc: Kees Cook <keescook@...gle.com>; David Woodhouse <dwmw2@...radead.org>; Chandler Carruth <chandlerc@...gle.com>; Kreitzer, David L <david.l.kreitzer@...el.com>; Grischenko, Andrei L <andrei.l.grischenko@...el.com>; rnk@...gle.com; LLVM Developers <llvm-dev@...ts.llvm.org>; ehsan@...illa.com; Tayree, Coby <coby.tayree@...el.com>; Matthias Braun <matze@...unis.de>; Dean Michael Berris <dean.berris@...il.com>; James Y Knight <jyknight@...gle.com>; Guenter Roeck <linux@...ck-us.net>; X86 ML <x86@...nel.org>; LKML <linux-kernel@...r.kernel.org>; Alan Cox <gnomes@...rguk.ukuu.org.uk>; Rik van Riel <riel@...hat.com>; Andi Kleen <ak@...ux.intel.com>; Josh Poimboeuf <jpoimboe@...hat.com>; Tom Lendacky <thomas.lendacky@....com>; Linus Torvalds <torvalds@...ux-foundation.org>; Jiri Kosina <jikos@...nel.org>; Andy Lutomirski <luto@...capital.net>; Hansen, Dave <dave.hansen@...el.com>; Tim Chen <tim.c.chen@...ux.intel.com>; Greg Kroah-Hartman <gregkh@...ux-foundation.org>; Paul Turner <pjt@...gle.com>; Stephen Hines <srhines@...gle.com>; Nick Desaulniers <ndesaulniers@...gle.com>
Subject: Re: clang asm-goto support (Was Re: [PATCH v2] x86/retpoline: Add clang support)

On Wed, Feb 14, 2018 at 08:33:39AM +0000, Yatsina, Marina wrote:
> I hope this will give this issue a push forward and we will find a 
> solution that will not prevent llvm from compiling linux kernel.

That solution is asm-goto. We (linux kernel) are not going to support something like it. It's going to be asm-goto or bust. The feature is over 7 years old by now, deal with it.

If you ever get to the point where it makes sense to build a kernel with LLVM, then you can bike-shed with the GCC team on new features, until then tough luck.
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.