linux-kernel - Re: [PATCH] x86/apic: Move pending intr check code into it's own function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vemc056wdhNvxw03OXcdzB5LE1Pu7Y84rf8ks6K0U5q5A@mail.gmail.com>
Date:   Wed, 14 Feb 2018 13:39:09 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Dou Liyang <douly.fnst@...fujitsu.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        x86@...nel.org, Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>, ebiederm@...ssion.com,
        Baoquan He <bhe@...hat.com>
Subject: Re: [PATCH] x86/apic: Move pending intr check code into it's own function

On Wed, Feb 14, 2018 at 8:24 AM, Dou Liyang <douly.fnst@...fujitsu.com> wrote:

Yes, I see you just moved the old code, but it might make sense to
update later the following.

> +                       for (j = 31; j >= 0; j--) {
> +                               if (value & (1<<j)) {

for_each_set_bit()

> +                                       ack_APIC_irq();
> +                                       acked++;
> +                               }
> +                       }

> +                       printk(KERN_ERR "LAPIC pending interrupts after %d EOI\n",
> +                              acked);

pr_err()

-- 
With Best Regards,
Andy Shevchenko