linux-kernel - Re: [PATCH] ubifs: Fix synced_i_size calculation for xattr inodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3040988.j6LFxaOeXC@blindfold>
Date:   Wed, 14 Feb 2018 13:46:42 +0100
From:   Richard Weinberger <richard@....at>
To:     linux-mtd@...ts.infradead.org
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] ubifs: Fix synced_i_size calculation for xattr inodes

Am Mittwoch, 14. Februar 2018, 12:02:48 CET schrieb Richard Weinberger:
> In ubifs_jnl_update() we sync parent and child inodes to the flash,
> in case of xattrs, the parent inode (AKA host inode) has a non-zero
> data_len. Therefore we need to adjust synced_i_size too.
> 
> This issue was reported by ubifs self tests unter a xattr related work
> load.
> UBIFS error (ubi0:0 pid 1896): dbg_check_synced_i_size: ui_size is 4,
> synced_i_size is 0, but inode is clean UBIFS error (ubi0:0 pid 1896):
> dbg_check_synced_i_size: i_ino 65, i_mode 0x81a4, i_size 4
> 
> Cc: <stable@...r.kernel.org>
> Fixes: 1e51764a3c2a ("UBIFS: add new flash file system")
> Signed-off-by: Richard Weinberger <richard@....at>
> ---
>  fs/ubifs/journal.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c
> index 04c4ec6483e5..e3e1e093db81 100644
> --- a/fs/ubifs/journal.c
> +++ b/fs/ubifs/journal.c
> @@ -664,6 +664,8 @@ int ubifs_jnl_update(struct ubifs_info *c, const struct
> inode *dir, finish_reservation(c);
>  	spin_lock(&ui->ui_lock);
>  	ui->synced_i_size = ui->ui_size;
> +	if (xent)
> +		host_ui->synced_i_size = host_ui->ui_size;
>  	spin_unlock(&ui->ui_lock);

Reviewing my own patch on LKML helps a lot.
We need to take host_ui->ui_lock too...

Thanks,
//richard