linux-kernel - Re: [PATCH] selftests/futex: Fix line continuation in Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180214020352.GB5786@fury>
Date:   Tue, 13 Feb 2018 18:03:52 -0800
From:   Darren Hart <dvhart@...radead.org>
To:     Shuah Khan <shuahkh@....samsung.com>
Cc:     Daniel Díaz <daniel.diaz@...aro.org>,
        linux-kselftest@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Shuah Khan <shuah@...nel.org>,
        "open list:FUTEX SUBSYSTEM" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] selftests/futex: Fix line continuation in Makefile

On Tue, Feb 13, 2018 at 06:45:54PM -0700, Shuah Khan wrote:
> On 02/13/2018 06:33 PM, Darren Hart wrote:
> > On Tue, Feb 13, 2018 at 02:26:46PM -0700, Shuah Khan wrote:
> >> On 02/07/2018 10:24 AM, Daniel Díaz wrote:
> >>> The Makefile lacks a couple of line continuation backslashes
> >>> in an `if' clause, which produces an error while make'ing:
> >>>
> >>>   $ make
> >>>   make[1]: Entering directory `/[...]/linux/tools/testing/selftests/futex'
> >>>   /bin/sh: -c: line 5: syntax error: unexpected end of file
> >>>   make[1]: *** [all] Error 1
> >>>   make[1]: Leaving directory `/[...]/linux/tools/testing/selftests/futex'
> >>>   make: *** [all] Error 2
> >>>
> > 
> > What is the failure scenario here? Is this shell specific? What does /bin/sh
> > point to for you?
> 
> My understanding is that this problem is seen with make versions prior to 4.x.
> This specific problem is seen with make version 3.81
> 
> I will let Daniel Díaz share details on his environment.

OK, thanks Shuah. I think this would be important to capture in the commit
message.

-- 
Darren Hart
VMware Open Source Technology Center