linux-kernel - Re: [PATCH 3/3] clk: exynos5433: Add CLK_IGNORE_UNUSED flag to sclk_ioclk_i2s1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <847021bf-d8b0-2070-86b3-fa63ce5e0517@samsung.com>
Date:   Wed, 14 Feb 2018 15:52:50 +0100
From:   Sylwester Nawrocki <s.nawrocki@...sung.com>
To:     Chanwoo Choi <cw00.choi@...sung.com>
Cc:     linux-clk@...r.kernel.org, sboyd@...eaurora.org,
        mturquette@...libre.com, linux-samsung-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        b.zolnierkie@...sung.com, m.szyprowski@...sung.com
Subject: Re: [PATCH 3/3] clk: exynos5433: Add CLK_IGNORE_UNUSED flag to
 sclk_ioclk_i2s1_bclk

On 02/06/2018 05:08 AM, Chanwoo Choi wrote:
> On 2018년 02월 05일 23:22, Sylwester Nawrocki wrote:
>> The sclk_ioclk_i2s1_bclk clock is not currently handled by any driver
>> and disabling this clock by the clk core prevents proper operation
>> of the I2S1 block. CLK_IGNORE_UNUSED flag is added as a temporary fix.
>>
>> Signed-off-by: Sylwester Nawrocki <s.nawrocki@...sung.com>
>> ---
>>  drivers/clk/samsung/clk-exynos5433.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c
>> index d74361736e64..15177f74e125 100644
>> --- a/drivers/clk/samsung/clk-exynos5433.c
>> +++ b/drivers/clk/samsung/clk-exynos5433.c
>> @@ -1680,7 +1680,7 @@ static const struct samsung_gate_clock peric_gate_clks[] __initconst = {
>>  			ENABLE_SCLK_PERIC, 11, CLK_SET_RATE_PARENT, 0),
>>  	GATE(CLK_SCLK_IOCLK_I2S1_BCLK, "sclk_ioclk_i2s1_bclk",
>>  			"ioclk_i2s1_bclk_in", ENABLE_SCLK_PERIC, 10,
>> -			CLK_SET_RATE_PARENT, 0),
>> +			CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED, 0),
>>  	GATE(CLK_SCLK_SPDIF, "sclk_spdif", "sclk_spdif_peric",
>>  			ENABLE_SCLK_PERIC, 8, CLK_SET_RATE_PARENT, 0),
>>  	GATE(CLK_SCLK_PCM1, "sclk_pcm1", "sclk_pcm1_peric",
>>
> If any device driver handles the sclk_ioclk_i2s1_bclk on later,
> CLK_IGNORE_UNUSED will be ignored. Looks good to me.
> 
> Reviewed-by: Chanwoo Choi <cw00.choi@...sung.com>

Thanks, I have applied the patch to clk/samsung tree.