linux-kernel - Re: [PATCH] PCI: qcom: use regulator bluk api for apq8064 supplies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3b256b44-d3fe-9022-ed3b-b671ba5cadd1@linaro.org>
Date:   Wed, 14 Feb 2018 16:14:59 +0000
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     stanimir.varbanov@...aro.org, svarbanov@...sol.com,
        linux-pci@...r.kernel.org, bhelgaas@...gle.com,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: qcom: use regulator bluk api for apq8064 supplies



On 14/02/18 15:35, Bjorn Andersson wrote:
>> +	res->supplies[1].supply = "vdda_phy";
>> +	res->supplies[1].supply = "vdda_refclk";
> 2
> 
>> +	ret = devm_regulator_bulk_get(dev, QCOM_PCIE_2_1_0_MAX_SUPPLY,
> Use ARRAY_SIZE(res->supplies) instead.
Thanks, Will fix it and send a new one.

--srini
> 
>> +				      res->supplies);
>> +	if (ret)
>> +		return ret;
>>   
> Other than that, this looks good.