linux-kernel - Re: [PATCH] siox: fix possible buffer overflow in device_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180214170021.pf2di46t2ggfepim@pengutronix.de>
Date:   Wed, 14 Feb 2018 18:00:21 +0100
From:   Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
To:     Gavin Schenk <g.schenk@...elmann.de>
Cc:     linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
        dcb314@...mail.com, kernel@...gutronix.de
Subject: Re: [PATCH] siox: fix possible buffer overflow in device_add_store

Hello,

On Wed, Feb 14, 2018 at 03:25:02PM +0100, Gavin Schenk wrote:
> Width 20 given in format string is larger than destination
> buffer 'type[20]', use %19s to prevent overflowing it.
> 
> Fixes: bbecb07fa0af ("siox: new driver framework for eckelmann SIOX")
> Reported-by: David Binderman <dcb314@...mail.com>
> Signed-off-by: Gavin Schenk <g.schenk@...elmann.de>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |