linux-kernel - Re: [PATCH] platform/x86: ideapad-laptop: Increase timeout to wait for EC answer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 14 Feb 2018 21:29:29 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Aaron Ma <aaron.ma@...onical.com>
Cc:     Ike Panhc <ike.pan@...onical.com>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: ideapad-laptop: Increase timeout to wait
 for EC answer

On Sun, Feb 11, 2018 at 11:18 AM, Aaron Ma <aaron.ma@...onical.com> wrote:
> Lenovo E41-20 needs more time than 100ms to read VPC,
> the funtion keys always failed responding.
> Increase timeout to get the value from VPC, then
> the funtion keys like mic mute key work well.
>

Pushed to my review and testing queue, thanks!

> Signed-off-by: Aaron Ma <aaron.ma@...onical.com>
> ---
>  drivers/platform/x86/ideapad-laptop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> index 5b6f18b18801..535199c9e6bc 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -113,7 +113,7 @@ MODULE_PARM_DESC(no_bt_rfkill, "No rfkill for bluetooth.");
>  /*
>   * ACPI Helpers
>   */
> -#define IDEAPAD_EC_TIMEOUT (100) /* in ms */
> +#define IDEAPAD_EC_TIMEOUT (200) /* in ms */
>
>  static int read_method_int(acpi_handle handle, const char *method, int *val)
>  {
> --
> 2.14.3
>



-- 
With Best Regards,
Andy Shevchenko