linux-kernel - Re: [PATCH 2/2] mmc: bcm2835: print some informational messages during reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180214204733.7987d16c@naga.suse.cz>
Date:   Wed, 14 Feb 2018 20:47:33 +0100
From:   Michal Suchánek <msuchanek@...e.de>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Michal Suchanek <msuchanek@...e.de>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com,
        Eric Anholt <eric@...olt.net>,
        Stefan Wahren <stefan.wahren@...e.com>,
        Gerd Hoffmann <kraxel@...hat.com>,
        "Gustavo A. R. Silva" <garsilva@...eddedor.com>,
        Julia Lawall <Julia.Lawall@...6.fr>, linux-mmc@...r.kernel.org,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mmc: bcm2835: print some informational messages
 during reset

On Wed, 14 Feb 2018 08:50:16 -0800
Florian Fainelli <f.fainelli@...il.com> wrote:

> On February 14, 2018 6:38:58 AM PST, Michal Suchanek
> <msuchanek@...e.de> wrote:
> >The previous patch does reset during hardware error so make the reset
> >progress more visible.  
> 
> Based on your previous email it looks like this can happen quite
> frequently so we might be spamming the kernel log with such reset
> messages. Turning this into a debug print would not be great either,
> how about a custom sysfs attribute counting the number of times a
> reset was done?

Since every such message happens when the system stalls for like half a
minute I don't think there will be that many until somebody notices
something is amiss. It might be also helpful in diagnosing if other
cards lock up in different way - for me the DMA shutdown is short so I
guess it's the mmc host that is locked up and the DMA engine is fine.
It might look differently on different systems, though.

I understand that adding messages it somewhat controversial so I added
them in separate patch.

Thanks

Michal