linux-kernel - Re: [PATCH v3 4/8] MIPS: mscc: Add initial support for Microsemi MIPS SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOFm3uHTMbr=uTHr73JMFkscb86NMgucuopeQt_5AiOUiQZu=g@mail.gmail.com>
Date:   Wed, 14 Feb 2018 22:38:35 +0100
From:   Philippe Ombredanne <pombredanne@...b.com>
To:     Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:     James Hogan <jhogan@...nel.org>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Linux MIPS <linux-mips@...ux-mips.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 4/8] MIPS: mscc: Add initial support for Microsemi MIPS SoCs

Alexandre,

On Wed, Feb 14, 2018 at 5:51 PM, James Hogan <jhogan@...nel.org> wrote:
> On Tue, Jan 16, 2018 at 11:12:36AM +0100, Alexandre Belloni wrote:

...

>> diff --git a/arch/mips/mscc/Platform b/arch/mips/mscc/Platform
>> new file mode 100644
>> index 000000000000..9ae874c8f136
>> --- /dev/null
>> +++ b/arch/mips/mscc/Platform
>> @@ -0,0 +1,12 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR MIT)
>> +#
>> +# Microsemi MIPS SoC support
>> +#
>> +# License: Dual MIT/GPL

IMHO you should remove this line as it exactly repeats the
SPDX-License-Identifier: (GPL-2.0 OR MIT) line in a less clear and
precise way.
The whole purpose of the SPDX things is to make licensing eventually
as clear ass possible
Thanks!
-- 
Cordially
Philippe Ombredanne