linux-kernel - Re: [PATCH 3/3] percpu: allow select gfp to be passed to underlying allocators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180215214148.GV695913@devbig577.frc2.facebook.com>
Date:   Thu, 15 Feb 2018 13:41:48 -0800
From:   Tejun Heo <tj@...nel.org>
To:     Dennis Zhou <dennisszhou@...il.com>
Cc:     Christoph Lameter <cl@...ux.com>,
        Daniel Borkmann <daniel@...earbox.net>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] percpu: allow select gfp to be passed to underlying
 allocators

Hello,

On Thu, Feb 15, 2018 at 10:08:16AM -0600, Dennis Zhou wrote:
> +/* the whitelisted flags that can be passed to the backing allocators */
> +#define gfp_percpu_mask(gfp) (((gfp) & (__GFP_NORETRY | __GFP_NOWARN)) | \
> +			      GFP_KERNEL)

Isn't there just one place where gfp comes in from outside?  If so,
this looks like a bit of overkill.  Can't we just filter there?

Thanks.

-- 
tejun