linux-kernel - Re: [PATCH v2] ASoC: rt5645: Introduce mapping for ACPI-defined GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cb4736e2-bcc0-c8da-efd9-7d5ea7f23d25@redhat.com>
Date:   Thu, 15 Feb 2018 10:17:45 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Carlo Caione <carlo@...one.org>,
        open list <linux-kernel@...r.kernel.org>
Cc:     Linux Upstreaming Team <linux@...lessm.com>, bardliao@...ltek.com,
        oder_chiou@...ltek.com, alsa-devel@...a-project.org,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Carlo Caione <carlo@...lessm.com>
Subject: Re: [PATCH v2] ASoC: rt5645: Introduce mapping for ACPI-defined GPIO

Hi,

On 15-02-18 10:11, Carlo Caione wrote:
> On Fri, Feb 9, 2018 at 2:23 PM, Carlo Caione <carlo@...one.org> wrote:
>> From: Carlo Caione <carlo@...lessm.com>
>>
>> On at least one notebook (ECS EF20EA) the 'hp-detect' GPIO is defined in
>> the DSDT table by the ACPI GpioIo resources in _CRS. Add this mapping to
>> the rt5645 driver to enable the jack detection also on non-DT platforms.
> 
> Please do not merge this yet, I'll submit a V3 soon.
> Hans pointed out that on some BayTrail there is indeed an extra GPIO
> but it is used to enable the external speaker amplifier. Better to
> guard this by a quirk.

Thank you Carlo, note that the tablet I was talking about is a rt5651 based
tablet, but yes you never know for what reasons someone will put an extra
GPIO in the resources table, so guarding this with a quirk seems like a good
idea.

Regards,

Hans