linux-kernel - Re: [PATCH v2] rtc: isl12026: Add driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcnR2U3DgSCv5Lpj=UBQnzX7YCbvbxzv__cZmW_+VcidQ@mail.gmail.com>
Date:   Thu, 15 Feb 2018 16:35:38 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:     David Daney <david.daney@...ium.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>, linux-rtc@...r.kernel.org,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] rtc: isl12026: Add driver.

On Thu, Feb 15, 2018 at 3:15 PM, Alexandre Belloni
<alexandre.belloni@...e-electrons.com> wrote:
> On 15/02/2018 at 14:45:11 +0200, Andy Shevchenko wrote:
>> On Wed, Feb 14, 2018 at 2:55 AM, David Daney <david.daney@...ium.com> wrote:

>> > +#ifdef CONFIG_OF
>>
>> Remove this ugly #ifdef. Your driver OF only one.
>>
>
> Well, it is DT only because you asked for that on v1.

Yes, and I asked to remove these #ifdef:s there as well.

-- 
With Best Regards,
Andy Shevchenko