[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <f4abe1a9-e128-ad68-8a4c-1034eabcfc1d@linux.vnet.ibm.com>
Date: Thu, 15 Feb 2018 08:24:51 +0530
From: Anshuman Khandual <khandual@...ux.vnet.ibm.com>
To: Bart Van Assche <Bart.VanAssche@....com>,
"chris@...is-wilson.co.uk" <chris@...is-wilson.co.uk>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"tvrtko.ursulin@...el.com" <tvrtko.ursulin@...el.com>,
"jthumshirn@...e.de" <jthumshirn@...e.de>,
"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
"axboe@...nel.dk" <axboe@...nel.dk>
Subject: Re: [PATCH] lib/scatterlist: Add SG_CHAIN and SG_EMARK macros for LSB
encodings
On 02/14/2018 09:33 PM, Bart Van Assche wrote:
> On Wed, 2018-02-14 at 10:28 +0530, Anshuman Khandual wrote:
>> +#define SG_CHAIN 0x01
>> +#define SG_EMARK 0x02
>
> Hello Anshuman,
>
> As you probably know constants that do not have a suffix are of type int. Please
> consider to add suffix "UL" to these constants to avoid that the compiler could
> take an undesired decision when e.g. converting ~SG_CHAIN from int to unsigned
> long.
Sure, will do.
Powered by blists - more mailing lists