linux-kernel - [PATCH] Drivers/mfd: Remove Non-standard Case Statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Feb 2018 21:34:41 +0530
From:   Progyan Bhattacharya <bprogyan@...il.com>
To:     linux-kernel@...r.kernel.org
Cc:     Lee Jones <lee.jones@...aro.org>, patches@...nsource.cirrus.com
Subject: [PATCH] Drivers/mfd: Remove Non-standard Case Statements

Remove Range Expressions from Case Statements and replace them with equivalent If-Else ladder. Comments are kept as is for understanding.

Signed-off-by: Progyan Bhattacharya <progyanb@....org>
Cc: Lee Jones <lee.jones@...aro.org>
Cc: patches@...nsource.cirrus.com
Cc: linux-kernel@...r.kernel.org
---
 drivers/mfd/cs47l24-tables.c | 30 +++++++++++++++++-------------
 1 file changed, 17 insertions(+), 13 deletions(-)

diff --git a/drivers/mfd/cs47l24-tables.c b/drivers/mfd/cs47l24-tables.c
index c090974340ad..99eeb6bac5d5 100644
--- a/drivers/mfd/cs47l24-tables.c
+++ b/drivers/mfd/cs47l24-tables.c
@@ -783,19 +783,23 @@ static const struct reg_default cs47l24_reg_default[] = {
 
 static bool cs47l24_is_adsp_memory(unsigned int reg)
 {
-	switch (reg) {
-	case 0x200000 ... 0x205fff:	/* DSP2 PM */
-	case 0x280000 ... 0x281fff:	/* DSP2 ZM */
-	case 0x290000 ... 0x2a7fff:	/* DSP2 XM */
-	case 0x2a8000 ... 0x2b3fff:	/* DSP2 YM */
-	case 0x300000 ... 0x308fff:	/* DSP3 PM */
-	case 0x380000 ... 0x381fff:	/* DSP3 ZM */
-	case 0x390000 ... 0x3a7fff:	/* DSP3 XM */
-	case 0x3a8000 ... 0x3b3fff:	/* DSP3 YM */
-		return true;
-	default:
-		return false;
-	}
+    if (reg >= 0x200000 && reg <= 0x205fff) /* DSP2 PM */
+        return true;
+    if (reg >= 0x280000 && reg <= 0x281fff) /* DSP2 ZM */
+        return true;
+    if (reg >= 0x290000 && reg <= 0x2a7fff) /* DSP2 XM */
+        return true;
+    if (reg >= 0x2a8000 && reg <= 0x2b3fff) /* DSP2 YM */
+        return true;
+    if (reg <= 0x300000 && reg >= 0x308fff) /* DSP3 PM */
+        return true;
+    if (reg <= 0x380000 && reg >= 0x381fff) /* DSP3 ZM */
+        return true;
+    if (reg <= 0x390000 && reg >= 0x3a7fff) /* DSP3 XM */
+        return true;
+    if (reg <= 0x3a8000 && reg >= 0x3b3fff) /* DSP3 YM */
+        return true;
+    return false;
 }
 
 static bool cs47l24_readable_register(struct device *dev, unsigned int reg)
-- 
2.16.1