linux-kernel - Re: [PATCH v3 0/5] crypto: ahash.c: Require export/import in ahash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6b29116a-c39c-9813-34a0-d5c05bd30c9d@denx.de>
Date:   Thu, 15 Feb 2018 17:27:32 +0100
From:   Marek Vasut <marex@...x.de>
To:     Herbert Xu <herbert@...dor.apana.org.au>,
        Kamil Konieczny <k.konieczny@...tner.samsung.com>
Cc:     linux-crypto@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Sonic Zhang <sonic.zhang@...log.com>,
        Fabio Estevam <fabio.estevam@...escale.com>,
        Shawn Guo <shawn.guo@...aro.org>,
        Tom Lendacky <thomas.lendacky@....com>,
        Jan Engelhardt <jengelh@...i.de>,
        Arvind Yadav <arvind.yadav.cs@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Joakim Bech <joakim.bech@...aro.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/5] crypto: ahash.c: Require export/import in ahash

On 02/15/2018 04:41 PM, Herbert Xu wrote:
> On Thu, Jan 18, 2018 at 07:33:59PM +0100, Kamil Konieczny wrote:
>> First four patches add empty hash export and import functions to each driver,
>> with the same behaviour as in crypto framework. The last one drops them from
>> crypto framework. Last one for ahash.c depends on all previous.
>>
>> Changes in v3:
>> added change for bfin_crc.c
>> make this a patchset, instead of unreleated patches
>> make commit message more descriptive
>>
>> Kamil Konieczny (5):
>>   crypto: mxs-dcp: Add empty hash export and import
>>   crypto: n2_core: Add empty hash export and import
>>   crypto: ux500/hash: Add empty export and import
>>   crypto: bfin_crc: Add empty hash export and import
>>   crypto: ahash.c: Require export/import in ahash
>>
>>  crypto/ahash.c                        | 18 ++----------------
>>  drivers/crypto/bfin_crc.c             | 12 ++++++++++++
>>  drivers/crypto/mxs-dcp.c              | 14 ++++++++++++++
>>  drivers/crypto/n2_core.c              | 12 ++++++++++++
>>  drivers/crypto/ux500/hash/hash_core.c | 18 ++++++++++++++++++
>>  5 files changed, 58 insertions(+), 16 deletions(-)
> 
> All applied.  Thanks.

This makes no sense, cfr my comment on 5/5

Seems like if the driver doesn't implement those, the core can easily
detect that and perform the necessary action. Moving the checks out of
core seems like the wrong thing to do, rather you should enhance the
checks in core if they're insufficient in my opinion.

-- 
Best regards,
Marek Vasut