linux-kernel - Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180215165028.GA25181@hirez.programming.kicks-ass.net>
Date:   Thu, 15 Feb 2018 17:50:28 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Patrick Bellasi <patrick.bellasi@....com>
Cc:     Vincent Guittot <vincent.guittot@...aro.org>, mingo@...nel.org,
        linux-kernel@...r.kernel.org, valentin.schneider@....com,
        morten.rasmussen@...s.arm.com, brendan.jackman@....com,
        dietmar.eggemann@....com
Subject: Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed

On Thu, Feb 15, 2018 at 03:22:47PM +0000, Patrick Bellasi wrote:
> > >  static struct {
> > >  	cpumask_var_t idle_cpus_mask;
> > >  	atomic_t nr_cpus;
> > > +	int has_blocked;		/* Idle CPUS has blocked load */
> 
> Why not "bool"?
> 
Because then he gets me yelling that sizeof(_Bool) is undefined and the
whole structure layout goes out the window :-)

Never use bool in a composite type.